Commit f485849a authored by Oleksij Rempel's avatar Oleksij Rempel Committed by David S. Miller
Browse files

net: usb: lan78xx: Extract PHY interrupt acknowledgment to helper 



Move the PHY interrupt acknowledgment logic from lan78xx_link_reset()
to a new helper function lan78xx_phy_int_ack(). This simplifies the
code and prepares for reusing the acknowledgment logic independently
from the full link reset process, such as when using phylink.

No functional change intended.

Signed-off-by: default avatarOleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: default avatarThangaraj Samynathan <thangaraj.s@microchip.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8ba1f33c

drivers/net/usb/lan78xx.c

+15 −1
Original line number Diff line number Diff line
@@ -1636,6 +1636,20 @@ static int lan78xx_mac_reset(struct lan78xx_net *dev) 
	return ret;

}



/**

 * lan78xx_phy_int_ack - Acknowledge PHY interrupt

 * @dev: pointer to the LAN78xx device structure

 *

 * This function acknowledges the PHY interrupt by setting the

 * INT_STS_PHY_INT_ bit in the interrupt status register (INT_STS).

 *

 * Return: 0 on success or a negative error code on failure.

 */

static int lan78xx_phy_int_ack(struct lan78xx_net *dev)

{

	return lan78xx_write_reg(dev, INT_STS, INT_STS_PHY_INT_);

}



static int lan78xx_link_reset(struct lan78xx_net *dev)

{

	struct phy_device *phydev = dev->net->phydev;
@@ -1644,7 +1658,7 @@ static int lan78xx_link_reset(struct lan78xx_net *dev) 
	u32 buf;



	/* clear LAN78xx interrupt status */

	ret = lan78xx_write_reg(dev, INT_STS, INT_STS_PHY_INT_);

	ret = lan78xx_phy_int_ack(dev);

	if (unlikely(ret < 0))

		return ret;