Commit f495bd7e authored by David Hildenbrand's avatar David Hildenbrand Committed by Andrew Morton
Browse files

mm/rmap: keep mapcount untouched for device-exclusive entries 

Now that conversion to device-exclusive does no longer perform an rmap
walk and all page_vma_mapped_walk() users were taught to properly handle
device-exclusive entries, let's treat device-exclusive entries just as if
they would be present, similar to how we handle device-private entries
already.

This fixes swapout/migration/split/hwpoison of folios with
device-exclusive entries.

We only had to take care of page_vma_mapped_walk() users, because these
traditionally assume pte_present().  Other page table walkers already have
to handle !pte_present(), and some of them might simply skip them (e.g.,
MADV_PAGEOUT) if they are not specialized on them.  This change doesn't
modify the latter.

Note that while folios with device-exclusive PTEs can now get migrated,
khugepaged will not collapse a THP if there is device-exclusive PTE. 
Doing so might also not be desired if the device frequently performs
atomics to the same page.  Similarly, KSM will never merge order-0 folios
that are device-exclusive.

Link: https://lkml.kernel.org/r/20250210193801.781278-17-david@redhat.com


Fixes: b756a3b5 ("mm: device exclusive memory access")
Signed-off-by: default avatarDavid Hildenbrand <david@redhat.com>
Tested-by: default avatarAlistair Popple <apopple@nvidia.com>
Cc: Alex Shi <alexs@kernel.org>
Cc: Danilo Krummrich <dakr@kernel.org>
Cc: Dave Airlie <airlied@gmail.com>
Cc: Jann Horn <jannh@google.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>
Cc: Jerome Glisse <jglisse@redhat.com>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Liam Howlett <liam.howlett@oracle.com>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Lyude <lyude@redhat.com>
Cc: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: Peter Xu <peterx@redhat.com>
Cc: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: SeongJae Park <sj@kernel.org>
Cc: Simona Vetter <simona.vetter@ffwll.ch>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Yanteng Si <si.yanteng@linux.dev>
Cc: Barry Song <v-songbaohua@oppo.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 1f3ac4c5

mm/memory.c

+1 −16
Original line number Diff line number Diff line
@@ -741,20 +741,6 @@ static void restore_exclusive_pte(struct vm_area_struct *vma, 


	VM_BUG_ON_FOLIO(pte_write(pte) && (!folio_test_anon(folio) &&

					   PageAnonExclusive(page)), folio);



	/*

	 * No need to take a page reference as one was already

	 * created when the swap entry was made.

	 */

	if (folio_test_anon(folio))

		folio_add_anon_rmap_pte(folio, page, vma, address, RMAP_NONE);

	else

		/*

		 * Currently device exclusive access only supports anonymous

		 * memory so the entry shouldn't point to a filebacked page.

		 */

		WARN_ON_ONCE(1);



	set_pte_at(vma->vm_mm, address, ptep, pte);



	/*
@@ -1626,7 +1612,6 @@ static inline int zap_nonpresent_ptes(struct mmu_gather *tlb, 
		 */

		WARN_ON_ONCE(!vma_is_anonymous(vma));

		rss[mm_counter(folio)]--;

		if (is_device_private_entry(entry))

		folio_remove_rmap_pte(folio, page, vma);

		folio_put(folio);

	} else if (!non_swap_entry(entry)) {

mm/rmap.c

+0 −7
Original line number Diff line number Diff line
@@ -2511,13 +2511,6 @@ struct page *make_device_exclusive(struct mm_struct *mm, unsigned long addr, 
	/* The pte is writable, uffd-wp does not apply. */

	set_pte_at(mm, addr, fw.ptep, swp_pte);



	/*

	 * TODO: The device-exclusive PFN swap PTE holds a folio reference but

	 * does not count as a mapping (mapcount), which is wrong and must be

	 * fixed, otherwise RMAP walks don't behave as expected.

	 */

	folio_remove_rmap_pte(folio, page, vma);



	folio_walk_end(&fw, vma);

	mmu_notifier_invalidate_range_end(&range);

	*foliop = folio;