Commit f4ca4f5a authored by Pali Rohár's avatar Pali Rohár Committed by Steve French
Browse files

cifs: Fix parsing reparse point with native symlink in SMB1 non-UNICODE session 



SMB1 NT_TRANSACT_IOCTL/FSCTL_GET_REPARSE_POINT even in non-UNICODE mode
returns reparse buffer in UNICODE/UTF-16 format.

This is because FSCTL_GET_REPARSE_POINT is NT-based IOCTL which does not
distinguish between 8-bit non-UNICODE and 16-bit UNICODE modes and its path
buffers are always encoded in UTF-16.

This change fixes reading of native symlinks in SMB1 when UNICODE session
is not active.

Fixes: ed3e0a14 ("smb: client: implement ->query_reparse_point() for SMB1")
Signed-off-by: default avatarPali Rohár <pali@kernel.org>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 1f486606

fs/smb/client/smb1ops.c

+1 −2
Original line number Diff line number Diff line
@@ -1000,12 +1000,11 @@ static int cifs_parse_reparse_point(struct cifs_sb_info *cifs_sb, 
{

	struct reparse_data_buffer *buf;

	TRANSACT_IOCTL_RSP *io = rsp_iov->iov_base;

	bool unicode = !!(io->hdr.Flags2 & SMBFLG2_UNICODE);

	u32 plen = le16_to_cpu(io->ByteCount);



	buf = (struct reparse_data_buffer *)((__u8 *)&io->hdr.Protocol +

					     le32_to_cpu(io->DataOffset));

	return parse_reparse_point(buf, plen, cifs_sb, full_path, unicode, data);

	return parse_reparse_point(buf, plen, cifs_sb, full_path, true, data);

}



static bool