Commit f5023219 authored by Tom Rix's avatar Tom Rix Committed by Jonathan Cameron
Browse files

iio: scd4x: check return of scd4x_write_and_fetch 



Clang static analysis reports this problem
scd4x.c:474:10: warning: The left operand of '==' is a
  garbage value
  if (val == 0xff) {
      ~~~ ^
val is only set from a successful call to scd4x_write_and_fetch()
So check it's return.

Fixes: 49d22b69 ("drivers: iio: chemical: Add support for Sensirion SCD4x CO2 sensor")
Signed-off-by: default avatarTom Rix <trix@redhat.com>
Link: https://lore.kernel.org/r/20220301025223.223223-1-trix@redhat.com


Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 460bfa65

drivers/iio/chemical/scd4x.c

+4 −1
Original line number Diff line number Diff line
@@ -471,12 +471,15 @@ static ssize_t calibration_forced_value_store(struct device *dev, 
	ret = scd4x_write_and_fetch(state, CMD_FRC, arg, &val, sizeof(val));

	mutex_unlock(&state->lock);



	if (ret)

		return ret;



	if (val == 0xff) {

		dev_err(dev, "forced calibration has failed");

		return -EINVAL;

	}



	return ret ?: len;

	return len;

}



static IIO_DEVICE_ATTR_RW(calibration_auto_enable, 0);