Commit f529b891 authored by Timur Tabi's avatar Timur Tabi Committed by Danilo Krummrich
Browse files

drm/nouveau: remove unused increment in gm200_flcn_pio_imem_wr 



The 'tag' parameter is passed by value and is not actually used after
being incremented, so remove the increment.  It's the function that calls
gm200_flcn_pio_imem_wr that is supposed to (and does) increment 'tag'.

Fixes: 0e44c217 ("drm/nouveau/flcn: new code to load+boot simple HS FWs (VPR scrubber)")
Reviewed-by: default avatarPhilipp Stanner <phasta@kernel.org>
Signed-off-by: default avatarTimur Tabi <ttabi@nvidia.com>
Link: https://lore.kernel.org/r/20250813001004.2986092-2-ttabi@nvidia.com


Signed-off-by: default avatarDanilo Krummrich <dakr@kernel.org>
parent 66e82b6e

drivers/gpu/drm/nouveau/nvkm/falcon/gm200.c

+1 −1
Original line number Diff line number Diff line
@@ -103,7 +103,7 @@ gm200_flcn_pio_imem_wr_init(struct nvkm_falcon *falcon, u8 port, bool sec, u32 i 
static void

gm200_flcn_pio_imem_wr(struct nvkm_falcon *falcon, u8 port, const u8 *img, int len, u16 tag)

{

	nvkm_falcon_wr32(falcon, 0x188 + (port * 0x10), tag++);

	nvkm_falcon_wr32(falcon, 0x188 + (port * 0x10), tag);

	while (len >= 4) {

		nvkm_falcon_wr32(falcon, 0x184 + (port * 0x10), *(u32 *)img);

		img += 4;