Commit f533fa14 authored by Shyam Sundar S K's avatar Shyam Sundar S K Committed by Hans de Goede
Browse files

platform/x86/amd/pmf: dump policy binary data 



Sometimes policy binary retrieved from the BIOS maybe incorrect that can
end up in failing to enable the Smart PC solution feature.

Use print_hex_dump_debug() to dump the policy binary in hex, so that we
debug the issues related to the binary even before sending that to TA.

Reviewed-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarShyam Sundar S K <Shyam-sundar.S-k@amd.com>
Link: https://lore.kernel.org/r/20231212014705.2017474-13-Shyam-sundar.S-k@amd.com


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 10817f28

drivers/platform/x86/amd/pmf/tee-if.c

+9 −0
Original line number Diff line number Diff line
@@ -276,6 +276,12 @@ static int amd_pmf_start_policy_engine(struct amd_pmf_dev *dev) 
}



#ifdef CONFIG_AMD_PMF_DEBUG

static void amd_pmf_hex_dump_pb(struct amd_pmf_dev *dev)

{

	print_hex_dump_debug("(pb):  ", DUMP_PREFIX_OFFSET, 16, 1, dev->policy_buf,

			     dev->policy_sz, false);

}



static ssize_t amd_pmf_get_pb_data(struct file *filp, const char __user *buf,

				   size_t length, loff_t *pos)

{
@@ -299,6 +305,7 @@ static ssize_t amd_pmf_get_pb_data(struct file *filp, const char __user *buf, 
	dev->policy_buf = new_policy_buf;

	dev->policy_sz = length;



	amd_pmf_hex_dump_pb(dev);

	ret = amd_pmf_start_policy_engine(dev);

	if (ret)

		return -EINVAL;
@@ -324,6 +331,7 @@ static void amd_pmf_remove_pb(struct amd_pmf_dev *dev) 
#else

static void amd_pmf_open_pb(struct amd_pmf_dev *dev, struct dentry *debugfs_root) {}

static void amd_pmf_remove_pb(struct amd_pmf_dev *dev) {}

static void amd_pmf_hex_dump_pb(struct amd_pmf_dev *dev) {}

#endif



static int amd_pmf_get_bios_buffer(struct amd_pmf_dev *dev)
@@ -338,6 +346,7 @@ static int amd_pmf_get_bios_buffer(struct amd_pmf_dev *dev) 


	memcpy(dev->policy_buf, dev->policy_base, dev->policy_sz);



	amd_pmf_hex_dump_pb(dev);

	if (pb_side_load)

		amd_pmf_open_pb(dev, dev->dbgfs_dir);