Commit f548c11a authored by Vasileios Amoiridis's avatar Vasileios Amoiridis Committed by Jonathan Cameron
Browse files

iio: light: rpr0521: Use generic iio_pollfunc_store_time() 



The custom rpr0521_trigger_consumer_store_time() is registered as trigger
handler in the devm_iio_triggered_buffer_setup() function. This function
is called from the calling of the iio_trigger_poll() used in the
sysfs/hrt triggers and it is not used anywhere else in this driver.

The irq handler of the driver is the rpr0521_drdy_irq_handler() which
saves the timestamp and then wakes the irq thread. The irq thread is
the rpr0521_drdy_irq_thread() function which checks if the irq came
from the sensor and wakes up the trigger threaded handler through
iio_trigger_poll_nested() or returns IRQ_NONE in case the irq didn't
come from this sensor.

This means that in the current driver, you can't reach the
rpr0521_trigger_consumer_store_time() when the device's irq is
triggered. This means that the extra check of iio_trigger_using_own()
is redundant since it will always be false so the general
iio_pollfunc_store_time() can be used.

Signed-off-by: default avatarVasileios Amoiridis <vassilisamir@gmail.com>
Link: https://patch.msgid.link/20240922162041.525896-2-vassilisamir@gmail.com


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent eeebe393

drivers/iio/light/rpr0521.c

+1 −13
Original line number Diff line number Diff line
@@ -438,18 +438,6 @@ static irqreturn_t rpr0521_drdy_irq_thread(int irq, void *private) 
	return IRQ_NONE;

}



static irqreturn_t rpr0521_trigger_consumer_store_time(int irq, void *p)

{

	struct iio_poll_func *pf = p;

	struct iio_dev *indio_dev = pf->indio_dev;



	/* Other trigger polls store time here. */

	if (!iio_trigger_using_own(indio_dev))

		pf->timestamp = iio_get_time_ns(indio_dev);



	return IRQ_WAKE_THREAD;

}



static irqreturn_t rpr0521_trigger_consumer_handler(int irq, void *p)

{

	struct iio_poll_func *pf = p;
@@ -1016,7 +1004,7 @@ static int rpr0521_probe(struct i2c_client *client) 
		/* Trigger consumer setup */

		ret = devm_iio_triggered_buffer_setup(indio_dev->dev.parent,

			indio_dev,

			rpr0521_trigger_consumer_store_time,

			iio_pollfunc_store_time,

			rpr0521_trigger_consumer_handler,

			&rpr0521_buffer_setup_ops);

		if (ret < 0) {