Commit f5527f01 authored by Al Viro's avatar Al Viro Committed by Alexei Starovoitov
Browse files

bpf: Get rid of redundant 3rd argument of prepare_seq_file() 



Remove 3rd argument in prepare_seq_file() to clean up the code a bit.

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Acked-by: default avatarYonghong Song <yonghong.song@linux.dev>
Link: https://lore.kernel.org/r/20250615004719.GE3011112@ZenIV


Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent 85cd83fe

kernel/bpf/bpf_iter.c

+5 −6
Original line number Diff line number Diff line
@@ -38,8 +38,7 @@ static DEFINE_MUTEX(link_mutex); 
/* incremented on every opened seq_file */

static atomic64_t session_id;



static int prepare_seq_file(struct file *file, struct bpf_iter_link *link,

			    const struct bpf_iter_seq_info *seq_info);

static int prepare_seq_file(struct file *file, struct bpf_iter_link *link);



static void bpf_iter_inc_seq_num(struct seq_file *seq)

{
@@ -257,7 +256,7 @@ static int iter_open(struct inode *inode, struct file *file) 
{

	struct bpf_iter_link *link = inode->i_private;



	return prepare_seq_file(file, link, __get_seq_info(link));

	return prepare_seq_file(file, link);

}



static int iter_release(struct inode *inode, struct file *file)
@@ -586,9 +585,9 @@ static void init_seq_meta(struct bpf_iter_priv_data *priv_data, 
	priv_data->done_stop = false;

}



static int prepare_seq_file(struct file *file, struct bpf_iter_link *link,

			    const struct bpf_iter_seq_info *seq_info)

static int prepare_seq_file(struct file *file, struct bpf_iter_link *link)

{

	const struct bpf_iter_seq_info *seq_info = __get_seq_info(link);

	struct bpf_iter_priv_data *priv_data;

	struct bpf_iter_target_info *tinfo;

	struct bpf_prog *prog;
@@ -653,7 +652,7 @@ int bpf_iter_new_fd(struct bpf_link *link) 
	}



	iter_link = container_of(link, struct bpf_iter_link, link);

	err = prepare_seq_file(file, iter_link, __get_seq_info(iter_link));

	err = prepare_seq_file(file, iter_link);

	if (err)

		goto free_file;