Commit f580786e authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Greg Kroah-Hartman
Browse files

staging: gpib: Make GPIB_NI_PCI_ISA depend on HAS_IOPORT 



After commit 78ecb037 ("staging: gpib: make port I/O code
conditional"), building tnt4882.ko on platforms without HAS_IOPORT (such
as hexagon and s390) fails with:

  ERROR: modpost: "inb_wrapper" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
  ERROR: modpost: "inw_wrapper" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
  ERROR: modpost: "nec7210_locking_ioport_write_byte" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
  ERROR: modpost: "nec7210_locking_ioport_read_byte" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
  ERROR: modpost: "outb_wrapper" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
  ERROR: modpost: "outw_wrapper" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!

Only allow tnt4882.ko to be built when CONFIG_HAS_IOPORT is set to avoid
this build failure, as this driver unconditionally needs it.

Fixes: 78ecb037 ("staging: gpib: make port I/O code conditional")
Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
Tested-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Link: https://lore.kernel.org/r/20241123-gpib-tnt4882-depends-on-has_ioport-v1-1-033c58b64751@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cdd30ebb

drivers/staging/gpib/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -62,6 +62,7 @@ config GPIB_CEC_PCI 
config GPIB_NI_PCI_ISA

	tristate "NI PCI/ISA compatible boards"

	depends on ISA_BUS || PCI || PCMCIA

	depends on HAS_IOPORT

	select GPIB_COMMON

	select GPIB_NEC7210

	help