Unverified Commit f5843dc8 authored by Chen-Yu Tsai's avatar Chen-Yu Tsai Committed by AngeloGioacchino Del Regno
Browse files

arm64: dts: mt8183-kukui: clean up regulator tree 



Some regulators in the kukui device tree are modeled incorrectly. Some
are missing supplies and some switches are incorrectly modeled as
voltage regulators. A pass-through was incorrectly modeled as a
regulator.

Add supplies where missing, remove voltage constraints for "switches",
and drop the "bl_pp5000" pass-through.

This depends on commit 2a99858c ("arm64: dts: mediatek: mt8183-kukui:
Add PMIC regulator supplies") for reg_vsys.

Fixes: cd894e27 ("arm64: dts: mt8183: Add krane-sku176 board")
Fixes: f15722c0 ("arm64: dts: mt8183: Add pwm and backlight node")
Signed-off-by: default avatarChen-Yu Tsai <wenst@chromium.org>
Link: https://lore.kernel.org/r/20240625095441.3474194-1-wenst@chromium.org


Signed-off-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
parent ec5c04ab

arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi

+6 −16
Original line number Diff line number Diff line
@@ -24,7 +24,7 @@ chosen { 
	backlight_lcd0: backlight_lcd0 {

		compatible = "pwm-backlight";

		pwms = <&pwm0 0 500000>;

		power-supply = <&bl_pp5000>;

		power-supply = <&reg_vsys>;

		enable-gpios = <&pio 176 0>;

		brightness-levels = <0 1023>;

		num-interpolated-steps = <1023>;
@@ -47,10 +47,9 @@ clk32k: oscillator1 { 
	it6505_pp18_reg: regulator0 {

		compatible = "regulator-fixed";

		regulator-name = "it6505_pp18";

		regulator-min-microvolt = <1800000>;

		regulator-max-microvolt = <1800000>;

		gpio = <&pio 178 0>;

		enable-active-high;

		vin-supply = <&pp1800_alw>;

	};



	lcd_pp3300: regulator1 {
@@ -62,27 +61,16 @@ lcd_pp3300: regulator1 { 
		regulator-boot-on;

	};



	bl_pp5000: regulator2 {

		compatible = "regulator-fixed";

		regulator-name = "bl_pp5000";

		regulator-min-microvolt = <5000000>;

		regulator-max-microvolt = <5000000>;

		regulator-always-on;

		regulator-boot-on;

	};



	mmc1_fixed_power: regulator3 {

		compatible = "regulator-fixed";

		regulator-name = "mmc1_power";

		regulator-min-microvolt = <3300000>;

		regulator-max-microvolt = <3300000>;

		vin-supply = <&pp3300_alw>;

	};



	mmc1_fixed_io: regulator4 {

		compatible = "regulator-fixed";

		regulator-name = "mmc1_io";

		regulator-min-microvolt = <1800000>;

		regulator-max-microvolt = <1800000>;

		vin-supply = <&pp1800_alw>;

	};



	pp1800_alw: regulator5 {
@@ -92,6 +80,7 @@ pp1800_alw: regulator5 { 
		regulator-boot-on;

		regulator-min-microvolt = <1800000>;

		regulator-max-microvolt = <1800000>;

		vin-supply = <&reg_vsys>;

	};



	pp3300_alw: regulator6 {
@@ -101,6 +90,7 @@ pp3300_alw: regulator6 { 
		regulator-boot-on;

		regulator-min-microvolt = <3300000>;

		regulator-max-microvolt = <3300000>;

		vin-supply = <&reg_vsys>;

	};



	/* system wide semi-regulated power rail from charger */