Commit f5860c88 authored by Yiling Chen's avatar Yiling Chen Committed by Alex Deucher
Browse files

drm/amd/display: Remove unnecessary eDP power down 



[why]
When first time of link training is fail,
eDP would be powered down and
would not be powered up for next retry link training.
It causes that all of retry link linking would be fail.

[how]
We has extracted both power up and down sequence from
enable/disable link output function before DCN32.
We remov eDP power down in dcn32_disable_link_output().

Reviewed-by: default avatarCharlene Liu <charlene.liu@amd.com>
Signed-off-by: default avatarYiling Chen <yi-ling.chen2@amd.com>
Signed-off-by: default avatarTom Chung <chiahsuan.chung@amd.com>
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent c7ccfc0d

drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c

+6 −6
Original line number Diff line number Diff line
@@ -1399,12 +1399,12 @@ void dcn32_disable_link_output(struct dc_link *link, 


	link_hwss->disable_link_output(link, link_res, signal);

	link->phy_state.symclk_state = SYMCLK_OFF_TX_OFF;



	if (signal == SIGNAL_TYPE_EDP &&

			link->dc->hwss.edp_power_control &&

			!link->skip_implict_edp_power_control)

		link->dc->hwss.edp_power_control(link, false);

	else if (dmcu != NULL && dmcu->funcs->unlock_phy)

	/*

	 * Add the logic to extract BOTH power up and power down sequences

	 * from enable/disable link output and only call edp panel control

	 * in enable_link_dp and disable_link_dp once.

	 */

	if (dmcu != NULL && dmcu->funcs->unlock_phy)

		dmcu->funcs->unlock_phy(dmcu);



	dc->link_srv->dp_trace_source_sequence(link, DPCD_SOURCE_SEQ_AFTER_DISABLE_LINK_PHY);