Commit f58e66be authored by Ilpo Järvinen's avatar Ilpo Järvinen Committed by Shuah Khan
Browse files

selftests/resctrl: Remove mongrp from CMT test 



The CMT selftest instantiates a monitor group to read LLC occupancy.
Since the test also creates a control group, it is unnecessary to
create another one for monitoring because control groups already
provide monitoring too.

Remove the unnecessary monitor group from the CMT selftest.

Suggested-by: default avatarReinette Chatre <reinette.chatre@intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tested-by: default avatarBabu Moger <babu.moger@amd.com>
Reviewed-by: default avatarReinette Chatre <reinette.chatre@intel.com>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent 64b07951

tools/testing/selftests/resctrl/cmt_test.c

+2 −3
Original line number Diff line number Diff line
@@ -17,12 +17,12 @@ 
#define MAX_DIFF_PERCENT	15



#define CON_MON_LCC_OCCUP_PATH		\

	"%s/%s/mon_groups/%s/mon_data/mon_L3_%02d/llc_occupancy"

	"%s/%s/mon_data/mon_L3_%02d/llc_occupancy"



static int cmt_init(const struct resctrl_val_param *param, int domain_id)

{

	sprintf(llc_occup_path, CON_MON_LCC_OCCUP_PATH, RESCTRL_PATH,

		param->ctrlgrp, param->mongrp, domain_id);

		param->ctrlgrp, domain_id);



	return 0;

}
@@ -146,7 +146,6 @@ static int cmt_run_test(const struct resctrl_test *test, const struct user_param 
	struct resctrl_val_param param = {

		.resctrl_val	= CMT_STR,

		.ctrlgrp	= "c1",

		.mongrp		= "m1",

		.filename	= RESULT_FILE_NAME,

		.mask		= ~(long_mask << n) & long_mask,

		.num_of_runs	= 0,