Commit f59cde8a authored by Michal Wajdeczko's avatar Michal Wajdeczko
Browse files

drm/xe/configfs: Fix 'parameter name omitted' errors 



On some configs and old compilers we can get following build errors:

  ../drivers/gpu/drm/xe/xe_configfs.h: In function 'xe_configfs_get_ctx_restore_mid_bb':
  ../drivers/gpu/drm/xe/xe_configfs.h:40:76: error: parameter name omitted
   static inline u32 xe_configfs_get_ctx_restore_mid_bb(struct pci_dev *pdev, enum xe_engine_class,
                                                                            ^~~~~~~~~~~~~~~~~~~~
  ../drivers/gpu/drm/xe/xe_configfs.h: In function 'xe_configfs_get_ctx_restore_post_bb':
  ../drivers/gpu/drm/xe/xe_configfs.h:42:77: error: parameter name omitted
   static inline u32 xe_configfs_get_ctx_restore_post_bb(struct pci_dev *pdev, enum xe_engine_class,
                                                                             ^~~~~~~~~~~~~~~~~~~~
when trying to define our configfs stub functions. Fix that.

Fixes: 7a4756b2 ("drm/xe/lrc: Allow to add user commands mid context switch")
Signed-off-by: default avatarMichal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: default avatarShuicheng Lin <shuicheng.lin@intel.com>
Link: https://patch.msgid.link/20260203193745.576-1-michal.wajdeczko@intel.com
parent 18443ff2

drivers/gpu/drm/xe/xe_configfs.h

+8 −4
Original line number Diff line number Diff line
@@ -23,9 +23,11 @@ bool xe_configfs_primary_gt_allowed(struct pci_dev *pdev); 
bool xe_configfs_media_gt_allowed(struct pci_dev *pdev);

u64 xe_configfs_get_engines_allowed(struct pci_dev *pdev);

bool xe_configfs_get_psmi_enabled(struct pci_dev *pdev);

u32 xe_configfs_get_ctx_restore_mid_bb(struct pci_dev *pdev, enum xe_engine_class,

u32 xe_configfs_get_ctx_restore_mid_bb(struct pci_dev *pdev,

				       enum xe_engine_class class,

				       const u32 **cs);

u32 xe_configfs_get_ctx_restore_post_bb(struct pci_dev *pdev, enum xe_engine_class,

u32 xe_configfs_get_ctx_restore_post_bb(struct pci_dev *pdev,

					enum xe_engine_class class,

					const u32 **cs);

#ifdef CONFIG_PCI_IOV

unsigned int xe_configfs_get_max_vfs(struct pci_dev *pdev);
@@ -40,9 +42,11 @@ static inline bool xe_configfs_primary_gt_allowed(struct pci_dev *pdev) { return 
static inline bool xe_configfs_media_gt_allowed(struct pci_dev *pdev) { return true; }

static inline u64 xe_configfs_get_engines_allowed(struct pci_dev *pdev) { return U64_MAX; }

static inline bool xe_configfs_get_psmi_enabled(struct pci_dev *pdev) { return false; }

static inline u32 xe_configfs_get_ctx_restore_mid_bb(struct pci_dev *pdev, enum xe_engine_class,

static inline u32 xe_configfs_get_ctx_restore_mid_bb(struct pci_dev *pdev,

						     enum xe_engine_class class,

						     const u32 **cs) { return 0; }

static inline u32 xe_configfs_get_ctx_restore_post_bb(struct pci_dev *pdev, enum xe_engine_class,

static inline u32 xe_configfs_get_ctx_restore_post_bb(struct pci_dev *pdev,

						      enum xe_engine_class class,

						      const u32 **cs) { return 0; }

#ifdef CONFIG_PCI_IOV

static inline unsigned int xe_configfs_get_max_vfs(struct pci_dev *pdev)