Commit f5bce28f authored by Alexey Kodanev's avatar Alexey Kodanev Committed by Jakub Kicinski
Browse files

net: sxgbe: fix potential NULL dereference in sxgbe_rx() 



Currently, when skb is null, the driver prints an error and then
dereferences skb on the next line.

To fix this, let's add a 'break' after the error message to switch
to sxgbe_rx_refill(), which is similar to the approach taken by the
other drivers in this particular case, e.g. calxeda with xgmac_rx().

Found during a code review.

Fixes: 1edb9ca6 ("net: sxgbe: add basic framework for Samsung 10Gb ethernet driver")
Signed-off-by: default avatarAlexey Kodanev <aleksei.kodanev@bell-sw.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20251121123834.97748-1-aleksei.kodanev@bell-sw.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 0ae9cfc4

drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c

+3 −1
Original line number Diff line number Diff line
@@ -1521,8 +1521,10 @@ static int sxgbe_rx(struct sxgbe_priv_data *priv, int limit) 


		skb = priv->rxq[qnum]->rx_skbuff[entry];



		if (unlikely(!skb))

		if (unlikely(!skb)) {

			netdev_err(priv->dev, "rx descriptor is not consistent\n");

			break;

		}



		prefetch(skb->data - NET_IP_ALIGN);

		priv->rxq[qnum]->rx_skbuff[entry] = NULL;