Unverified Commit f62c0602 authored by Johan Hovold's avatar Johan Hovold Committed by Mark Brown
Browse files

spi: mpc52xx: fix use-after-free on registration failure 

Make sure to disable and free the interrupts in case controller
registration fails to avoid a potential use-after-free and resource
leak.

This issue was flagged by Sashiko when reviewing a controller
deregistration fix.

Fixes: 42bbb709 ("powerpc/5200: Add mpc5200-spi (non-PSC) device driver")
Cc: stable@vger.kernel.org	# 2.6.33
Cc: Grant Likely <grant.likely@secretlab.ca>
Link: https://sashiko.dev/#/patchset/20260414134319.978196-1-johan%40kernel.org?part=3


Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20260421125800.1537361-1-johan@kernel.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 922f8c28

drivers/spi/spi-mpc52xx.c

+3 −0
Original line number Diff line number Diff line
@@ -498,6 +498,9 @@ static int mpc52xx_spi_probe(struct platform_device *op) 


 err_register:

	dev_err(&ms->host->dev, "initialization failed\n");

	free_irq(ms->irq0, ms);

	free_irq(ms->irq1, ms);

	cancel_work_sync(&ms->work);

 err_gpio:

	while (i-- > 0)

		gpiod_put(ms->gpio_cs[i]);