Commit f63182b4 authored by Daniele Ceraolo Spurio's avatar Daniele Ceraolo Spurio Committed by Rodrigo Vivi
Browse files

drm/xe/gsc: Trigger a driver flr to cleanup the GSC on unload 



GSC is only killed by an FLR, so we need to trigger one on unload to
make sure we stop it. This is because we assign a chunk of memory to
the GSC as part of the FW load, so we need to make sure it stops
using it when we release it to the system on driver unload. Note that
this is not a problem of the unload per-se, because the GSC will not
touch that memory unless there are requests for it coming from the
driver; therefore, no accesses will happen while Xe is not loaded,
but if we re-load the driver then the GSC might wake up and try to
access that old memory location again.

Signed-off-by: default avatarDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
Reviewed-by: default avatarJohn Harrison <John.C.Harrison@Intel.com>
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent aae84bf1

drivers/gpu/drm/xe/xe_gsc.c

+17 −0
Original line number Diff line number Diff line
@@ -130,6 +130,23 @@ static int gsc_upload(struct xe_gsc *gsc) 
		return err;

	}



	/*

	 * GSC is only killed by an FLR, so we need to trigger one on unload to

	 * make sure we stop it. This is because we assign a chunk of memory to

	 * the GSC as part of the FW load, so we need to make sure it stops

	 * using it when we release it to the system on driver unload. Note that

	 * this is not a problem of the unload per-se, because the GSC will not

	 * touch that memory unless there are requests for it coming from the

	 * driver; therefore, no accesses will happen while Xe is not loaded,

	 * but if we re-load the driver then the GSC might wake up and try to

	 * access that old memory location again.

	 * Given that an FLR is a very disruptive action (see the FLR function

	 * for details), we want to do it as the last action before releasing

	 * the access to the MMIO bar, which means we need to do it as part of

	 * mmio cleanup.

	 */

	xe->needs_flr_on_fini = true;



	err = emit_gsc_upload(gsc);

	if (err) {

		xe_gt_err(gt, "Failed to emit GSC FW upload (%pe)\n", ERR_PTR(err));