Commit f6443e01 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Linus Walleij
Browse files

pinctrl: don't put the reference to GPIO device in pinctrl_pins_show() 



The call to gpiod_to_gpio_device() does not increase the reference count
of the GPIO device struct so it must not be decreased. Remove the buggy
__free() decorator.

Fixes: 524fc108 ("pinctrl: stop using gpiod_to_chip()")
Reported-by: default avatarDavid Arcari <darcari@redhat.com>
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://lore.kernel.org/r/20240223123214.288181-1-brgl@bgdev.pl


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent cb4443f2

drivers/pinctrl/core.c

+1 −1
Original line number Diff line number Diff line
@@ -1644,7 +1644,7 @@ static int pinctrl_pins_show(struct seq_file *s, void *what) 
	const struct pinctrl_ops *ops = pctldev->desc->pctlops;

	unsigned int i, pin;

#ifdef CONFIG_GPIOLIB

	struct gpio_device *gdev __free(gpio_device_put) = NULL;

	struct gpio_device *gdev = NULL;

	struct pinctrl_gpio_range *range;

	int gpio_num;

#endif