Commit f644d21b authored by Daniel Wagner's avatar Daniel Wagner Committed by Keith Busch
Browse files

nvmet-fcloop: Remove remote port from list when unlinking 



The remote port is removed too late from fcloop_nports list. Remove it
when port is unregistered.

This prevents a busy loop in fcloop_exit, because it is possible the
remote port is found in the list and thus we will never progress.

The kernel log will be spammed with

  nvme_fcloop: fcloop_exit: Failed deleting remote port
  nvme_fcloop: fcloop_exit: Failed deleting target port

Signed-off-by: default avatarDaniel Wagner <dwagner@suse.de>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent 0e716cec

drivers/nvme/target/fcloop.c

+2 −5
Original line number Diff line number Diff line
@@ -995,11 +995,6 @@ fcloop_nport_free(struct kref *ref) 
{

	struct fcloop_nport *nport =

		container_of(ref, struct fcloop_nport, ref);

	unsigned long flags;



	spin_lock_irqsave(&fcloop_lock, flags);

	list_del(&nport->nport_list);

	spin_unlock_irqrestore(&fcloop_lock, flags);



	kfree(nport);

}
@@ -1357,6 +1352,8 @@ __unlink_remote_port(struct fcloop_nport *nport) 
		nport->tport->remoteport = NULL;

	nport->rport = NULL;



	list_del(&nport->nport_list);



	return rport;

}