Commit f64bd204 authored by Eric Dumazet's avatar Eric Dumazet Committed by Jakub Kicinski
Browse files

tcp: tcp_time_to_recover() cleanup 



tcp_time_to_recover() does not need the @flag argument.

Its first parameter can be marked const, and of tcp_sock type.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250618091246.1260322-1-edumazet@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c7d78566

net/ipv4/tcp_input.c

+3 −5
Original line number Diff line number Diff line
@@ -2336,10 +2336,8 @@ static bool tcp_check_sack_reneging(struct sock *sk, int *ack_flag) 
 * Main question: may we further continue forward transmission

 * with the same cwnd?

 */

static bool tcp_time_to_recover(struct sock *sk, int flag)

static bool tcp_time_to_recover(const struct tcp_sock *tp)

{

	struct tcp_sock *tp = tcp_sk(sk);



	/* Has loss detection marked at least one packet lost? */

	return tp->lost_out != 0;

}
@@ -3013,7 +3011,7 @@ static void tcp_fastretrans_alert(struct sock *sk, const u32 prior_snd_una, 


		tcp_identify_packet_loss(sk, ack_flag);

		if (icsk->icsk_ca_state != TCP_CA_Recovery) {

			if (!tcp_time_to_recover(sk, flag))

			if (!tcp_time_to_recover(tp))

				return;

			/* Undo reverts the recovery state. If loss is evident,

			 * starts a new recovery (e.g. reordering then loss);
@@ -3042,7 +3040,7 @@ static void tcp_fastretrans_alert(struct sock *sk, const u32 prior_snd_una, 
			tcp_try_undo_dsack(sk);



		tcp_identify_packet_loss(sk, ack_flag);

		if (!tcp_time_to_recover(sk, flag)) {

		if (!tcp_time_to_recover(tp)) {

			tcp_try_to_open(sk, flag);

			return;

		}