Unverified Commit f6551f78 authored by Rosen Penev's avatar Rosen Penev Committed by Andi Shyti
Browse files

i2c: rtl9300: use of instead of fwnode 



Avoids having to use to_of_node and just assign directly. This is an OF
only driver anyway.

Use _scoped for the for each loop to avoid refcount leaks.

Signed-off-by: default avatarRosen Penev <rosenp@gmail.com>
Reviewed-by: default avatarChris Packham <chris.packham@alliedtelesis.co.nz>
Signed-off-by: default avatarAndi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20251217063027.37987-3-rosenp@gmail.com
parent fc31008d

drivers/i2c/busses/i2c-rtl9300.c

+4 −5
Original line number Diff line number Diff line
@@ -371,7 +371,6 @@ static int rtl9300_i2c_probe(struct platform_device *pdev) 
{

	struct device *dev = &pdev->dev;

	struct rtl9300_i2c *i2c;

	struct fwnode_handle *child;

	const struct rtl9300_i2c_drv_data *drv_data;

	struct reg_field fields[F_NUM_FIELDS];

	u32 clock_freq, scl_num, sda_num;
@@ -415,15 +414,15 @@ static int rtl9300_i2c_probe(struct platform_device *pdev) 
		return ret;



	i = 0;

	device_for_each_child_node(dev, child) {

	for_each_child_of_node_scoped(dev->of_node, child) {

		struct rtl9300_i2c_chan *chan = &i2c->chans[i];

		struct i2c_adapter *adap = &chan->adap;



		ret = fwnode_property_read_u32(child, "reg", &sda_num);

		ret = of_property_read_u32(child, "reg", &sda_num);

		if (ret)

			return ret;



		ret = fwnode_property_read_u32(child, "clock-frequency", &clock_freq);

		ret = of_property_read_u32(child, "clock-frequency", &clock_freq);

		if (ret)

			clock_freq = I2C_MAX_STANDARD_MODE_FREQ;
@@ -449,7 +448,7 @@ static int rtl9300_i2c_probe(struct platform_device *pdev) 
		adap->retries = 3;

		adap->dev.parent = dev;

		i2c_set_adapdata(adap, chan);

		adap->dev.of_node = to_of_node(child);

		adap->dev.of_node = child;

		snprintf(adap->name, sizeof(adap->name), "%s SDA%d\n", dev_name(dev), sda_num);

		i++;