Commit f65966fe authored by Alexander Lobakin's avatar Alexander Lobakin Committed by Jakub Kicinski
Browse files

xdp: allow attaching already registered memory model to xdp_rxq_info 



One may need to register memory model separately from xdp_rxq_info. One
simple example may be XDP test run code, but in general, it might be
useful when memory model registering is managed by one layer and then
XDP RxQ info by a different one.
Allow such scenarios by adding a simple helper which "attaches"
already registered memory model to the desired xdp_rxq_info. As this
is mostly needed for Page Pool, add a special function to do that for
a &page_pool pointer.

Reviewed-by: default avatarToke Høiland-Jørgensen <toke@redhat.com>
Signed-off-by: default avatarAlexander Lobakin <aleksander.lobakin@intel.com>
Link: https://patch.msgid.link/20241203173733.3181246-5-aleksander.lobakin@intel.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent dcf3827c

include/net/xdp.h

+32 −0
Original line number Diff line number Diff line
@@ -356,6 +356,38 @@ void xdp_rxq_info_unreg_mem_model(struct xdp_rxq_info *xdp_rxq); 
int xdp_reg_mem_model(struct xdp_mem_info *mem,

		      enum xdp_mem_type type, void *allocator);

void xdp_unreg_mem_model(struct xdp_mem_info *mem);

int xdp_reg_page_pool(struct page_pool *pool);

void xdp_unreg_page_pool(const struct page_pool *pool);

void xdp_rxq_info_attach_page_pool(struct xdp_rxq_info *xdp_rxq,

				   const struct page_pool *pool);



/**

 * xdp_rxq_info_attach_mem_model - attach registered mem info to RxQ info

 * @xdp_rxq: XDP RxQ info to attach the memory info to

 * @mem: already registered memory info

 *

 * If the driver registers its memory providers manually, it must use this

 * function instead of xdp_rxq_info_reg_mem_model().

 */

static inline void

xdp_rxq_info_attach_mem_model(struct xdp_rxq_info *xdp_rxq,

			      const struct xdp_mem_info *mem)

{

	xdp_rxq->mem = *mem;

}



/**

 * xdp_rxq_info_detach_mem_model - detach registered mem info from RxQ info

 * @xdp_rxq: XDP RxQ info to detach the memory info from

 *

 * If the driver registers its memory providers manually and then attaches it

 * via xdp_rxq_info_attach_mem_model(), it must call this function before

 * xdp_rxq_info_unreg().

 */

static inline void xdp_rxq_info_detach_mem_model(struct xdp_rxq_info *xdp_rxq)

{

	xdp_rxq->mem = (struct xdp_mem_info){ };

}



/* Drivers not supporting XDP metadata can use this helper, which

 * rejects any room expansion for metadata as a result.

net/core/xdp.c

+56 −0
Original line number Diff line number Diff line
@@ -365,6 +365,62 @@ int xdp_rxq_info_reg_mem_model(struct xdp_rxq_info *xdp_rxq, 


EXPORT_SYMBOL_GPL(xdp_rxq_info_reg_mem_model);



/**

 * xdp_reg_page_pool - register &page_pool as a memory provider for XDP

 * @pool: &page_pool to register

 *

 * Can be used to register pools manually without connecting to any XDP RxQ

 * info, so that the XDP layer will be aware of them. Then, they can be

 * attached to an RxQ info manually via xdp_rxq_info_attach_page_pool().

 *

 * Return: %0 on success, -errno on error.

 */

int xdp_reg_page_pool(struct page_pool *pool)

{

	struct xdp_mem_info mem;



	return xdp_reg_mem_model(&mem, MEM_TYPE_PAGE_POOL, pool);

}

EXPORT_SYMBOL_GPL(xdp_reg_page_pool);



/**

 * xdp_unreg_page_pool - unregister &page_pool from the memory providers list

 * @pool: &page_pool to unregister

 *

 * A shorthand for manual unregistering page pools. If the pool was previously

 * attached to an RxQ info, it must be detached first.

 */

void xdp_unreg_page_pool(const struct page_pool *pool)

{

	struct xdp_mem_info mem = {

		.type	= MEM_TYPE_PAGE_POOL,

		.id	= pool->xdp_mem_id,

	};



	xdp_unreg_mem_model(&mem);

}

EXPORT_SYMBOL_GPL(xdp_unreg_page_pool);



/**

 * xdp_rxq_info_attach_page_pool - attach registered pool to RxQ info

 * @xdp_rxq: XDP RxQ info to attach the pool to

 * @pool: pool to attach

 *

 * If the pool was registered manually, this function must be called instead

 * of xdp_rxq_info_reg_mem_model() to connect it to the RxQ info.

 */

void xdp_rxq_info_attach_page_pool(struct xdp_rxq_info *xdp_rxq,

				   const struct page_pool *pool)

{

	struct xdp_mem_info mem = {

		.type	= MEM_TYPE_PAGE_POOL,

		.id	= pool->xdp_mem_id,

	};



	xdp_rxq_info_attach_mem_model(xdp_rxq, &mem);

}

EXPORT_SYMBOL_GPL(xdp_rxq_info_attach_page_pool);



/* XDP RX runs under NAPI protection, and in different delivery error

 * scenarios (e.g. queue full), it is possible to return the xdp_frame

 * while still leveraging this protection.  The @napi_direct boolean