Commit f67fbacd authored by carrion bent's avatar carrion bent Committed by Theodore Ts'o
Browse files

ext4: fix macro definition error of EXT4_DIRENT_HASH and EXT4_DIRENT_MINOR_HASH 



The macro parameter 'entry' of EXT4_DIRENT_HASH and
EXT4_DIRENT_MINOR_HASH was not used, but rather the variable 'de' was
directly used, which may be a local variable inside a function that
calls the macros.  Fortunately, all callers have passed in 'de' so
far, so this bug didn't have an effect.

Signed-off-by: default avatarcarrion bent <carrionbent@linux.alibaba.com>
Link: https://patch.msgid.link/1717652596-58760-1-git-send-email-carrionbent@linux.alibaba.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 985b67cd

fs/ext4/ext4.h

+2 −2
Original line number Diff line number Diff line
@@ -2338,9 +2338,9 @@ struct ext4_dir_entry_2 { 
	((struct ext4_dir_entry_hash *) \

		(((void *)(entry)) + \

		((8 + (entry)->name_len + EXT4_DIR_ROUND) & ~EXT4_DIR_ROUND)))

#define EXT4_DIRENT_HASH(entry) le32_to_cpu(EXT4_DIRENT_HASHES(de)->hash)

#define EXT4_DIRENT_HASH(entry) le32_to_cpu(EXT4_DIRENT_HASHES(entry)->hash)

#define EXT4_DIRENT_MINOR_HASH(entry) \

		le32_to_cpu(EXT4_DIRENT_HASHES(de)->minor_hash)

		le32_to_cpu(EXT4_DIRENT_HASHES(entry)->minor_hash)



static inline bool ext4_hash_in_dirent(const struct inode *inode)

{