Commit f6a45874 authored by Eric Biggers's avatar Eric Biggers
Browse files

crypto: arm64/ghash - Fix incorrect output from ghash-neon 



Commit 9a7c987f ("crypto: arm64/ghash - Use API partial block
handling") made ghash_finup() pass the wrong buffer to
ghash_do_simd_update().  As a result, ghash-neon now produces incorrect
outputs when the message length isn't divisible by 16 bytes.  Fix this.

(I didn't notice this earlier because this code is reached only on CPUs
that support NEON but not PMULL.  I haven't yet found a way to get
qemu-system-aarch64 to emulate that configuration.)

Fixes: 9a7c987f ("crypto: arm64/ghash - Use API partial block handling")
Cc: stable@vger.kernel.org
Reported-by: default avatarDiederik de Haas <diederik@cknow-tech.com>
Closes: https://lore.kernel.org/linux-crypto/DETXT7QI62KE.F3CGH2VWX1SC@cknow-tech.com/


Tested-by: default avatarDiederik de Haas <diederik@cknow-tech.com>
Acked-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Link: https://lore.kernel.org/r/20251209223417.112294-1-ebiggers@kernel.org


Signed-off-by: default avatarEric Biggers <ebiggers@kernel.org>
parent 6f7d9481

arch/arm64/crypto/ghash-ce-glue.c

+1 −1
Original line number Diff line number Diff line
@@ -133,7 +133,7 @@ static int ghash_finup(struct shash_desc *desc, const u8 *src, 
		u8 buf[GHASH_BLOCK_SIZE] = {};



		memcpy(buf, src, len);

		ghash_do_simd_update(1, ctx->digest, src, key, NULL,

		ghash_do_simd_update(1, ctx->digest, buf, key, NULL,

				     pmull_ghash_update_p8);

		memzero_explicit(buf, sizeof(buf));

	}