Unverified Commit f6bd2f63 authored by Alexis Belmonte's avatar Alexis Belmonte Committed by Ilpo Järvinen
Browse files

platform/x86: hp-wmi: Fix implementation of the platform_profile_omen_get function 



Fix ill-formed implementation of the platform_profile_omen_get function
introduced by the commit d2343023 ("platform/x86: hp-wmi: Fix
platform profile option switch bug on Omen and Victus laptops").
platform_profile_omen_get() is .profile_get function that should set
*profile and return 0 on success.

Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Fixes: d2343023 ("platform/x86: hp-wmi: Fix platform profile option switch bug on Omen and Victus laptops")
Signed-off-by: default avatarAlexis Belmonte <alexbelm48@gmail.com>
Reviewed-by: default avatarArmin Wolf <W_Armin@gmx.de>
Link: https://lore.kernel.org/r/ZpFnV8w1558BW7iZ@alexis-pc


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 1e02e317

drivers/platform/x86/hp/hp-wmi.c

+2 −4
Original line number Diff line number Diff line
@@ -1238,8 +1238,6 @@ static int platform_profile_omen_get_ec(enum platform_profile_option *profile) 
static int platform_profile_omen_get(struct platform_profile_handler *pprof,

				     enum platform_profile_option *profile)

{

	enum platform_profile_option selected_platform_profile;



	/*

	 * We directly return the stored platform profile, as the embedded

	 * controller will not accept switching to the performance option when
@@ -1253,9 +1251,9 @@ static int platform_profile_omen_get(struct platform_profile_handler *pprof, 
	 * See also omen_powersource_event.

	 */

	guard(mutex)(&active_platform_profile_lock);

	selected_platform_profile = active_platform_profile;

	*profile = active_platform_profile;



	return selected_platform_profile;

	return 0;

}



static bool has_omen_thermal_profile_ec_timer(void)