Commit f70181b3 authored by Tejas Vipin's avatar Tejas Vipin Committed by Douglas Anderson
Browse files

drm/panel: raydium-rm69380: transition to mipi_dsi wrapped functions 



Changes the raydium-rm69380 panel to use multi style functions for
improved error handling.

Reviewed-by: default avatarDouglas Anderson <dianders@chromium.org>
Signed-off-by: default avatarTejas Vipin <tejasvipin76@gmail.com>
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240914034341.897197-1-tejasvipin76@gmail.com
parent e6a1c403

drivers/gpu/drm/panel/panel-raydium-rm69380.c

+29 −64
Original line number Diff line number Diff line
@@ -46,108 +46,73 @@ static void rm69380_reset(struct rm69380_panel *ctx) 
static int rm69380_on(struct rm69380_panel *ctx)

{

	struct mipi_dsi_device *dsi = ctx->dsi[0];

	struct device *dev = &dsi->dev;

	int ret;

	struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };



	dsi->mode_flags |= MIPI_DSI_MODE_LPM;

	if (ctx->dsi[1])

		ctx->dsi[1]->mode_flags |= MIPI_DSI_MODE_LPM;



	mipi_dsi_dcs_write_seq(dsi, 0xfe, 0xd4);

	mipi_dsi_dcs_write_seq(dsi, 0x00, 0x80);

	mipi_dsi_dcs_write_seq(dsi, 0xfe, 0xd0);

	mipi_dsi_dcs_write_seq(dsi, 0x48, 0x00);

	mipi_dsi_dcs_write_seq(dsi, 0xfe, 0x26);

	mipi_dsi_dcs_write_seq(dsi, 0x75, 0x3f);

	mipi_dsi_dcs_write_seq(dsi, 0x1d, 0x1a);

	mipi_dsi_dcs_write_seq(dsi, 0xfe, 0x00);

	mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_WRITE_CONTROL_DISPLAY, 0x28);

	mipi_dsi_dcs_write_seq(dsi, 0xc2, 0x08);



	ret = mipi_dsi_dcs_set_tear_on(dsi, MIPI_DSI_DCS_TEAR_MODE_VBLANK);

	if (ret < 0) {

		dev_err(dev, "Failed to set tear on: %d\n", ret);

		return ret;

	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xfe, 0xd4);

	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x00, 0x80);

	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xfe, 0xd0);

	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x48, 0x00);

	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xfe, 0x26);

	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x75, 0x3f);

	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x1d, 0x1a);

	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xfe, 0x00);

	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_CONTROL_DISPLAY, 0x28);

	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc2, 0x08);



	mipi_dsi_dcs_set_tear_on_multi(&dsi_ctx, MIPI_DSI_DCS_TEAR_MODE_VBLANK);

	mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx);

	mipi_dsi_msleep(&dsi_ctx, 20);



	mipi_dsi_dcs_set_display_on_multi(&dsi_ctx);

	mipi_dsi_msleep(&dsi_ctx, 36);



	return dsi_ctx.accum_err;

}



	ret = mipi_dsi_dcs_exit_sleep_mode(dsi);

	if (ret < 0) {

		dev_err(dev, "Failed to exit sleep mode: %d\n", ret);

		return ret;

	}

	msleep(20);



	ret = mipi_dsi_dcs_set_display_on(dsi);

	if (ret < 0) {

		dev_err(dev, "Failed to set display on: %d\n", ret);

		return ret;

	}

	msleep(36);



	return 0;

}



static int rm69380_off(struct rm69380_panel *ctx)

static void rm69380_off(struct rm69380_panel *ctx)

{

	struct mipi_dsi_device *dsi = ctx->dsi[0];

	struct device *dev = &dsi->dev;

	int ret;

	struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };



	dsi->mode_flags &= ~MIPI_DSI_MODE_LPM;

	if (ctx->dsi[1])

		ctx->dsi[1]->mode_flags &= ~MIPI_DSI_MODE_LPM;



	ret = mipi_dsi_dcs_set_display_off(dsi);

	if (ret < 0) {

		dev_err(dev, "Failed to set display off: %d\n", ret);

		return ret;

	}

	msleep(35);



	ret = mipi_dsi_dcs_enter_sleep_mode(dsi);

	if (ret < 0) {

		dev_err(dev, "Failed to enter sleep mode: %d\n", ret);

		return ret;

	}

	msleep(20);



	return 0;

	mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);

	mipi_dsi_msleep(&dsi_ctx, 35);

	mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);

	mipi_dsi_msleep(&dsi_ctx, 20);

}



static int rm69380_prepare(struct drm_panel *panel)

{

	struct rm69380_panel *ctx = to_rm69380_panel(panel);

	struct device *dev = &ctx->dsi[0]->dev;

	int ret;



	ret = regulator_bulk_enable(ARRAY_SIZE(ctx->supplies), ctx->supplies);

	if (ret < 0) {

		dev_err(dev, "Failed to enable regulators: %d\n", ret);

	if (ret < 0)

		return ret;

	}



	rm69380_reset(ctx);



	ret = rm69380_on(ctx);

	if (ret < 0) {

		dev_err(dev, "Failed to initialize panel: %d\n", ret);

		gpiod_set_value_cansleep(ctx->reset_gpio, 1);

		regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies);

		return ret;

	}



	return 0;

	return ret;

}



static int rm69380_unprepare(struct drm_panel *panel)

{

	struct rm69380_panel *ctx = to_rm69380_panel(panel);

	struct device *dev = &ctx->dsi[0]->dev;

	int ret;



	ret = rm69380_off(ctx);

	if (ret < 0)

		dev_err(dev, "Failed to un-initialize panel: %d\n", ret);

	rm69380_off(ctx);



	gpiod_set_value_cansleep(ctx->reset_gpio, 1);

	regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies);