Commit f730fd53 authored by Uros Bizjak's avatar Uros Bizjak Committed by Peter Zijlstra
Browse files

cleanup: Remove address space of returned pointer 



Guard functions in local_lock.h are defined using DEFINE_GUARD() and
DEFINE_LOCK_GUARD_1() macros having lock type defined as pointer in
the percpu address space. The functions, defined by these macros
return value in generic address space, causing:

cleanup.h:157:18: error: return from pointer to non-enclosed address space

and

cleanup.h:214:18: error: return from pointer to non-enclosed address space

when strict percpu checks are enabled.

Add explicit casts to remove address space of the returned pointer.

Found by GCC's named address space checks.

Fixes: e4ab322f ("cleanup: Add conditional guard support")
Signed-off-by: default avatarUros Bizjak <ubizjak@gmail.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20240819074124.143565-1-ubizjak@gmail.com
parent d12b802f

include/linux/cleanup.h

+2 −2
Original line number Diff line number Diff line
@@ -290,7 +290,7 @@ static inline class_##_name##_t class_##_name##ext##_constructor(_init_args) \ 
#define DEFINE_GUARD(_name, _type, _lock, _unlock) \

	DEFINE_CLASS(_name, _type, if (_T) { _unlock; }, ({ _lock; _T; }), _type _T); \

	static inline void * class_##_name##_lock_ptr(class_##_name##_t *_T) \

	{ return *_T; }

	{ return (void *)(__force unsigned long)*_T; }



#define DEFINE_GUARD_COND(_name, _ext, _condlock) \

	EXTEND_CLASS(_name, _ext, \
@@ -347,7 +347,7 @@ static inline void class_##_name##_destructor(class_##_name##_t *_T) \ 
									\

static inline void *class_##_name##_lock_ptr(class_##_name##_t *_T)	\

{									\

	return _T->lock;						\

	return (void *)(__force unsigned long)_T->lock;			\

}