Commit f73780e7 authored by Zijun Hu's avatar Zijun Hu Committed by Rob Herring (Arm)
Browse files

of: property: Avoiding using uninitialized variable @imaplen in parse_interrupt_map() 



parse_interrupt_map() will use uninitialized variable @imaplen if fails
to get property 'interrupt-map'.

Fix by using the variable after successfully getting the property.

Fixes: e7985f43 ("of: property: Fix fw_devlink handling of interrupt-map")
Signed-off-by: default avatarZijun Hu <quic_zijuhu@quicinc.com>
Reviewed-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20250109-of_core_fix-v4-6-db8a72415b8c@quicinc.com


Signed-off-by: default avatarRob Herring (Arm) <robh@kernel.org>
parent e4c00c9b

drivers/of/property.c

+1 −1
Original line number Diff line number Diff line
@@ -1391,9 +1391,9 @@ static struct device_node *parse_interrupt_map(struct device_node *np, 
	addrcells = of_bus_n_addr_cells(np);



	imap = of_get_property(np, "interrupt-map", &imaplen);

	imaplen /= sizeof(*imap);

	if (!imap)

		return NULL;

	imaplen /= sizeof(*imap);



	imap_end = imap + imaplen;