Commit f752e79d authored by Tao Zhou's avatar Tao Zhou Committed by Alex Deucher
Browse files

drm/amdgpu: fix the calculation of RAS bad page number 



__amdgpu_ras_restore_bad_pages is responsible for the maintenance of bad
page number, drop the unnecessary bad page number update in the error
handling path of add_bad_pages.

Signed-off-by: default avatarTao Zhou <tao.zhou1@amd.com>
Reviewed-by: default avatarHawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 20952941

drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

+0 −4
Original line number Diff line number Diff line
@@ -3249,8 +3249,6 @@ int amdgpu_ras_add_bad_pages(struct amdgpu_device *adev, 
						/* deal with retire_unit records a time */

						ret = __amdgpu_ras_convert_rec_array_from_rom(adev,

										&bps[i], &err_data, nps);

						if (ret)

							con->bad_page_num -= adev->umc.retire_unit;

						i += (adev->umc.retire_unit - 1);

					} else {

						break;
@@ -3263,8 +3261,6 @@ int amdgpu_ras_add_bad_pages(struct amdgpu_device *adev, 
		for (; i < pages; i++) {

			ret = __amdgpu_ras_convert_rec_from_rom(adev,

				&bps[i], &err_data, nps);

			if (ret)

				con->bad_page_num -= adev->umc.retire_unit;

		}



		con->eh_data->count_saved = con->eh_data->count;