Commit f75efc8f authored by Tejun Heo's avatar Tejun Heo
Browse files

sched_ext: Fix stray scx_root usage in task_can_run_on_remote_rq() 



task_can_run_on_remote_rq() takes @sch but it is using scx_root when
incrementing SCX_EV_DISPATCH_LOCAL_DSQ_OFFLINE, which is inconsistent and
gets in the way of implementing multiple scheduler support. Use @sch
instead. As currently scx_root is the only possible scheduler instance, this
doesn't cause any behavior changes.

Acked-by: default avatarAndrea Righi <arighi@nvidia.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent edf005fa

kernel/sched/ext.c

+1 −2
Original line number Diff line number Diff line
@@ -1622,8 +1622,7 @@ static bool task_can_run_on_remote_rq(struct scx_sched *sch, 


	if (!scx_rq_online(rq)) {

		if (enforce)

			__scx_add_event(scx_root,

					SCX_EV_DISPATCH_LOCAL_DSQ_OFFLINE, 1);

			__scx_add_event(sch, SCX_EV_DISPATCH_LOCAL_DSQ_OFFLINE, 1);

		return false;

	}