Commit f763fd73 authored by Armin Wolf's avatar Armin Wolf Committed by Hans de Goede
Browse files

platform/x86: wmi: Remove debug_dump_wdg module param 



The functionality of dumping WDG entries is better provided by
userspace tools like "fwts wmi", which also does not suffer from
garbled printk output caused by pr_cont().

Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarArmin Wolf <W_Armin@gmx.de>
Link: https://lore.kernel.org/r/20231210202443.646427-2-W_Armin@gmx.de


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 23e65246

drivers/platform/x86/wmi.c

+0 −31
Original line number Diff line number Diff line
@@ -90,11 +90,6 @@ module_param(debug_event, bool, 0444); 
MODULE_PARM_DESC(debug_event,

		 "Log WMI Events [0/1]");



static bool debug_dump_wdg;

module_param(debug_dump_wdg, bool, 0444);

MODULE_PARM_DESC(debug_dump_wdg,

		 "Dump available WMI interfaces [0/1]");



static const struct acpi_device_id wmi_device_ids[] = {

	{"PNP0C14", 0},

	{"pnp0c14", 0},
@@ -597,29 +592,6 @@ acpi_status wmidev_block_set(struct wmi_device *wdev, u8 instance, const struct 
}

EXPORT_SYMBOL_GPL(wmidev_block_set);



static void wmi_dump_wdg(const struct guid_block *g)

{

	pr_info("%pUL:\n", &g->guid);

	if (g->flags & ACPI_WMI_EVENT)

		pr_info("\tnotify_id: 0x%02X\n", g->notify_id);

	else

		pr_info("\tobject_id: %2pE\n", g->object_id);

	pr_info("\tinstance_count: %d\n", g->instance_count);

	pr_info("\tflags: %#x", g->flags);

	if (g->flags) {

		if (g->flags & ACPI_WMI_EXPENSIVE)

			pr_cont(" ACPI_WMI_EXPENSIVE");

		if (g->flags & ACPI_WMI_METHOD)

			pr_cont(" ACPI_WMI_METHOD");

		if (g->flags & ACPI_WMI_STRING)

			pr_cont(" ACPI_WMI_STRING");

		if (g->flags & ACPI_WMI_EVENT)

			pr_cont(" ACPI_WMI_EVENT");

	}

	pr_cont("\n");



}



static void wmi_notify_debug(u32 value, void *context)

{

	struct acpi_buffer response = { ACPI_ALLOCATE_BUFFER, NULL };
@@ -1343,9 +1315,6 @@ static int parse_wdg(struct device *wmi_bus_dev, struct platform_device *pdev) 
	total = obj->buffer.length / sizeof(struct guid_block);



	for (i = 0; i < total; i++) {

		if (debug_dump_wdg)

			wmi_dump_wdg(&gblock[i]);



		if (!gblock[i].instance_count) {

			dev_info(wmi_bus_dev, FW_INFO "%pUL has zero instances\n", &gblock[i].guid);

			continue;