Commit f792a362 authored by Damien Le Moal's avatar Damien Le Moal Committed by Martin K. Petersen
Browse files

scsi: pm8001: Fix memory leak in pm8001_chip_fw_flash_update_req() 

In pm8001_chip_fw_flash_update_build(), if
pm8001_chip_fw_flash_update_build() fails, the struct fw_control_ex
allocated must be freed.

Link: https://lore.kernel.org/r/20220220031810.738362-23-damien.lemoal@opensource.wdc.com


Reviewed-by: default avatarJack Wang <jinpu.wang@ionos.com>
Signed-off-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 4c8f04b1

drivers/scsi/pm8001/pm8001_hwi.c

+3 −1
Original line number Diff line number Diff line
@@ -4873,8 +4873,10 @@ pm8001_chip_fw_flash_update_req(struct pm8001_hba_info *pm8001_ha, 
	ccb->ccb_tag = tag;

	rc = pm8001_chip_fw_flash_update_build(pm8001_ha, &flash_update_info,

		tag);

	if (rc)

	if (rc) {

		kfree(fw_control_context);

		pm8001_tag_free(pm8001_ha, tag);

	}



	return rc;

}