Commit f7e1fe45 authored by Matthew Auld's avatar Matthew Auld
Browse files

drm/xe/vram: fix lpfn check 



Technically we should check the lfpn value and not the place->lpfn, for
the case where the allocation itself could be as large as the entire
region and not be range based, which might result in incorrectly doing a
power-of-two roundup. The allocator itself will already ensure it's
contiguous underneath for such an allocation. This shouldn't fix any
current usecase, but never the less came up from some internal testing.

Signed-off-by: default avatarMatthew Auld <matthew.auld@intel.com>
Cc: Piotr Piórkowski <piotr.piorkowski@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: default avatarMatthew Brost <matthew.brost@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241119101926.190203-2-matthew.auld@intel.com
parent 4fe70f66

drivers/gpu/drm/xe/xe_ttm_vram_mgr.c

+1 −1
Original line number Diff line number Diff line
@@ -109,7 +109,7 @@ static int xe_ttm_vram_mgr_new(struct ttm_resource_manager *man, 
		goto error_unlock;

	}



	if (place->fpfn + (size >> PAGE_SHIFT) != place->lpfn &&

	if (place->fpfn + (size >> PAGE_SHIFT) != lpfn &&

	    place->flags & TTM_PL_FLAG_CONTIGUOUS) {

		size = roundup_pow_of_two(size);

		min_page_size = size;