Commit f7e79530 authored by Jacek Lawrynowicz's avatar Jacek Lawrynowicz Committed by Karol Wachowski
Browse files

accel/ivpu: Refactor priority_bands_show for readability 



Reduce code duplication and improve the overall readability of the debugfs
output for job scheduling priority bands.

Additionally fix clang-tidy warning about missing default case in the
switch statement.

Signed-off-by: default avatarJacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Reviewed-by: default avatarLizhi Hou <lizhi.hou@amd.com>
Signed-off-by: default avatarKarol Wachowski <karol.wachowski@linux.intel.com>
Link: https://lore.kernel.org/r/20250915103401.830045-1-karol.wachowski@linux.intel.com
parent 2274402a

drivers/accel/ivpu/ivpu_debugfs.c

+14 −24
Original line number Diff line number Diff line
@@ -398,35 +398,25 @@ static int dct_active_set(void *data, u64 active_percent) 


DEFINE_DEBUGFS_ATTRIBUTE(ivpu_dct_fops, dct_active_get, dct_active_set, "%llu\n");



static void print_priority_band(struct seq_file *s, struct ivpu_hw_info *hw,

				int band, const char *name)

{

	seq_printf(s, "%-9s: grace_period %9u process_grace_period %9u process_quantum %9u\n",

		   name,

		   hw->hws.grace_period[band],

		   hw->hws.process_grace_period[band],

		   hw->hws.process_quantum[band]);

}



static int priority_bands_show(struct seq_file *s, void *v)

{

	struct ivpu_device *vdev = s->private;

	struct ivpu_hw_info *hw = vdev->hw;



	for (int band = VPU_JOB_SCHEDULING_PRIORITY_BAND_IDLE;

	     band < VPU_JOB_SCHEDULING_PRIORITY_BAND_COUNT; band++) {

		switch (band) {

		case VPU_JOB_SCHEDULING_PRIORITY_BAND_IDLE:

			seq_puts(s, "Idle:     ");

			break;



		case VPU_JOB_SCHEDULING_PRIORITY_BAND_NORMAL:

			seq_puts(s, "Normal:   ");

			break;



		case VPU_JOB_SCHEDULING_PRIORITY_BAND_FOCUS:

			seq_puts(s, "Focus:    ");

			break;



		case VPU_JOB_SCHEDULING_PRIORITY_BAND_REALTIME:

			seq_puts(s, "Realtime: ");

			break;

		}



		seq_printf(s, "grace_period %9u process_grace_period %9u process_quantum %9u\n",

			   hw->hws.grace_period[band], hw->hws.process_grace_period[band],

			   hw->hws.process_quantum[band]);

	}

	print_priority_band(s, hw, VPU_JOB_SCHEDULING_PRIORITY_BAND_IDLE, "Idle");

	print_priority_band(s, hw, VPU_JOB_SCHEDULING_PRIORITY_BAND_NORMAL, "Normal");

	print_priority_band(s, hw, VPU_JOB_SCHEDULING_PRIORITY_BAND_FOCUS, "Focus");

	print_priority_band(s, hw, VPU_JOB_SCHEDULING_PRIORITY_BAND_REALTIME, "Realtime");



	return 0;

}