Commit f7ed0a7e authored by Karolina Stolarek's avatar Karolina Stolarek Committed by Arunpravin Paneer Selvam
Browse files

drm/ttm/tests: Use an init function from the helpers lib 



Add a new helper function that also initializes the device. Use it in
ttm_tt test suite and delete the local definition.

Signed-off-by: default avatarKarolina Stolarek <karolina.stolarek@intel.com>
Reviewed-by: default avatarMatthew Auld <matthew.auld@intel.com>
Reviewed-by: default avatarSomalapuram, Amaranath <asomalap@amd.com>
Signed-off-by: default avatarArunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/235f110c1bdd2da7fac62ec03d177a5160dba1d5.1718192625.git.karolina.stolarek@intel.com
parent dc501656

drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c

+14 −0
Original line number Diff line number Diff line
@@ -158,6 +158,20 @@ int ttm_test_devices_init(struct kunit *test) 
}

EXPORT_SYMBOL_GPL(ttm_test_devices_init);



int ttm_test_devices_all_init(struct kunit *test)

{

	struct ttm_test_devices *priv;



	priv = kunit_kzalloc(test, sizeof(*priv), GFP_KERNEL);

	KUNIT_ASSERT_NOT_NULL(test, priv);



	priv = ttm_test_devices_all(test);

	test->priv = priv;



	return 0;

}

EXPORT_SYMBOL_GPL(ttm_test_devices_all_init);



void ttm_test_devices_fini(struct kunit *test)

{

	ttm_test_devices_put(test, test->priv);

drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h

+1 −0
Original line number Diff line number Diff line
@@ -40,6 +40,7 @@ void ttm_test_devices_put(struct kunit *test, struct ttm_test_devices *devs); 


/* Generic init/fini for tests that only need DRM/TTM devices */

int ttm_test_devices_init(struct kunit *test);

int ttm_test_devices_all_init(struct kunit *test);

void ttm_test_devices_fini(struct kunit *test);



#endif // TTM_KUNIT_HELPERS_H

drivers/gpu/drm/ttm/tests/ttm_tt_test.c

+1 −14
Original line number Diff line number Diff line
@@ -15,19 +15,6 @@ struct ttm_tt_test_case { 
	uint32_t extra_pages_num;

};



static int ttm_tt_test_init(struct kunit *test)

{

	struct ttm_test_devices *priv;



	priv = kunit_kzalloc(test, sizeof(*priv), GFP_KERNEL);

	KUNIT_ASSERT_NOT_NULL(test, priv);



	priv = ttm_test_devices_all(test);

	test->priv = priv;



	return 0;

}



static const struct ttm_tt_test_case ttm_tt_init_basic_cases[] = {

	{

		.description = "Page-aligned size",
@@ -285,7 +272,7 @@ static struct kunit_case ttm_tt_test_cases[] = { 


static struct kunit_suite ttm_tt_test_suite = {

	.name = "ttm_tt",

	.init = ttm_tt_test_init,

	.init = ttm_test_devices_all_init,

	.exit = ttm_test_devices_fini,

	.test_cases = ttm_tt_test_cases,

};