Unverified Commit f8200348 authored by Gabor Juhos's avatar Gabor Juhos Committed by Mark Brown
Browse files

spi: spi-qpic-snand: don't hardcode ECC steps 



NAND devices with different page sizes requires different number
of ECC steps, yet the qcom_spi_ecc_init_ctx_pipelined() function
sets 4 steps in 'ecc_cfg' unconditionally.

The correct number of the steps is calculated earlier in the
function already, so use that instead of the hardcoded value.

Fixes: 7304d190 ("spi: spi-qpic: add driver for QCOM SPI NAND flash Interface")
Signed-off-by: default avatarGabor Juhos <j4g8y7@gmail.com>
Link: https://patch.msgid.link/20250723-qpic-snand-fix-steps-v1-1-d800695dde4c@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 71050521

drivers/spi/spi-qpic-snand.c

+1 −1
Original line number Diff line number Diff line
@@ -308,7 +308,7 @@ static int qcom_spi_ecc_init_ctx_pipelined(struct nand_device *nand) 
	ecc_cfg->bch_enabled = true;

	ecc_cfg->bytes = ecc_cfg->ecc_bytes_hw + ecc_cfg->spare_bytes + ecc_cfg->bbm_size;



	ecc_cfg->steps = 4;

	ecc_cfg->steps = cwperpage;

	ecc_cfg->cw_data = 516;

	ecc_cfg->cw_size = ecc_cfg->cw_data + ecc_cfg->bytes;

	bad_block_byte = mtd->writesize - ecc_cfg->cw_size * (cwperpage - 1) + 1;