Commit f8494d25 authored by Kent Overstreet's avatar Kent Overstreet Committed by Kent Overstreet
Browse files

bcachefs: Convert some WARN_ONs to WARN_ON_ONCE 



These warnings are symptomatic of something else going wrong, we don't
want them spamming up the logs as that'll make it harder to find the
real issue.

Signed-off-by: default avatarKent Overstreet <kent.overstreet@gmail.com>
parent 062afcba

fs/bcachefs/fs-io.c

+3 −3
Original line number Diff line number Diff line
@@ -1247,7 +1247,7 @@ static void bch2_writepage_io_done(struct bch_write_op *op) 
	 * racing with fallocate can cause us to add fewer sectors than

	 * expected - but we shouldn't add more sectors than expected:

	 */

	WARN_ON(io->op.i_sectors_delta > 0);

	WARN_ON_ONCE(io->op.i_sectors_delta > 0);



	/*

	 * (error (due to going RO) halfway through a page can screw that up
@@ -1434,7 +1434,7 @@ static int __bch2_writepage(struct folio *folio, 
				     sectors << 9, offset << 9));



		/* Check for writing past i_size: */

		WARN_ON((bio_end_sector(&w->io->op.wbio.bio) << 9) >

		WARN_ON_ONCE((bio_end_sector(&w->io->op.wbio.bio) << 9) >

			     round_up(i_size, block_bytes(c)));



		w->io->op.res.sectors += reserved_sectors;