Commit f88f1466 authored by Fengnan Chang's avatar Fengnan Chang Committed by Theodore Ts'o
Browse files

ext4: fix error code in ext4_commit_super 



We should set the error code when ext4_commit_super check argument failed.
Found in code review.
Fixes: c4be0c1d ("filesystem freeze: add error handling of write_super_lockfs/unlockfs").

Cc: stable@kernel.org
Signed-off-by: default avatarFengnan Chang <changfengnan@vivo.com>
Reviewed-by: default avatarAndreas Dilger <adilger@dilger.ca>
Link: https://lore.kernel.org/r/20210402101631.561-1-changfengnan@vivo.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent ac2f7ca5

fs/ext4/super.c

+4 −2
Original line number Diff line number Diff line
@@ -5585,8 +5585,10 @@ static int ext4_commit_super(struct super_block *sb) 
	struct buffer_head *sbh = EXT4_SB(sb)->s_sbh;

	int error = 0;



	if (!sbh || block_device_ejected(sb))

		return error;

	if (!sbh)

		return -EINVAL;

	if (block_device_ejected(sb))

		return -ENODEV;



	ext4_update_super(sb);