Commit f8993dc6 authored by Adrian Huang's avatar Adrian Huang Committed by Joerg Roedel
Browse files

iommu/amd: Remove unnecessary assignment 



From: Adrian Huang <ahuang12@lenovo.com>

The values of local variables are assigned after local variables
are declared, so no need to assign the initial value during the
variable declaration.

And, no need to assign NULL for the local variable 'ivrs_base'
after invoking acpi_put_table().

Signed-off-by: default avatarAdrian Huang <ahuang12@lenovo.com>
Acked-by: default avatarWill Deacon <will@kernel.org>
Link: https://lore.kernel.org/r/20201210021330.2022-1-adrianhuang0701@gmail.com


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent 6ee1d745

drivers/iommu/amd/init.c

+2 −3
Original line number Diff line number Diff line
@@ -1911,7 +1911,7 @@ static void print_iommu_info(void) 
static int __init amd_iommu_init_pci(void)

{

	struct amd_iommu *iommu;

	int ret = 0;

	int ret;



	for_each_iommu(iommu) {

		ret = iommu_init_pci(iommu);
@@ -2637,8 +2637,8 @@ static void __init free_dma_resources(void) 
static int __init early_amd_iommu_init(void)

{

	struct acpi_table_header *ivrs_base;

	int i, remap_cache_sz, ret;

	acpi_status status;

	int i, remap_cache_sz, ret = 0;

	u32 pci_id;



	if (!amd_iommu_detected)
@@ -2780,7 +2780,6 @@ static int __init early_amd_iommu_init(void) 
out:

	/* Don't leak any ACPI memory */

	acpi_put_table(ivrs_base);

	ivrs_base = NULL;



	return ret;

}