Commit f8bba143 authored by Sunil V L's avatar Sunil V L Committed by Rafael J. Wysocki
Browse files

ACPI: RISC-V: Implement function to reorder irqchip probe entries 



On RISC-V platforms, the RINTC structures should be probed before any
other interrupt controller structures and IMSIC before APLIC. This order
is established by using MADT sub table types which are ordered in the
incremental order from the RINTC. So, add the architecture function for
RISC-V to reorder the interrupt controller probing as per the hierarchy
like below.

  ACPI_MADT_TYPE_RINTC = 24,
  ACPI_MADT_TYPE_IMSIC = 25,
  ACPI_MADT_TYPE_APLIC = 26,
  ACPI_MADT_TYPE_PLIC = 27

This means processing all RINTC structures (in the order of appearance
in MADT), followed by IMSIC strucutre and then all APLIC/PLIC
structures.

Signed-off-by: default avatarSunil V L <sunilvl@ventanamicro.com>
Tested-by: default avatarBjörn Töpel <bjorn@rivosinc.com>
Link: https://patch.msgid.link/20240812005929.113499-11-sunilvl@ventanamicro.com


Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 01415e78

drivers/acpi/riscv/Makefile

+1 −1
Original line number Diff line number Diff line 
# SPDX-License-Identifier: GPL-2.0-only

obj-y					+= rhct.o init.o

obj-y					+= rhct.o init.o irq.o

obj-$(CONFIG_ACPI_PROCESSOR_IDLE)	+= cpuidle.o

obj-$(CONFIG_ACPI_CPPC_LIB)		+= cppc.o

drivers/acpi/riscv/irq.c

0 → 100644
+33 −0
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0-only

/*

 * Copyright (C) 2023-2024, Ventana Micro Systems Inc

 *	Author: Sunil V L <sunilvl@ventanamicro.com>

 */



#include <linux/acpi.h>

#include <linux/sort.h>



static int irqchip_cmp_func(const void *in0, const void *in1)

{

	struct acpi_probe_entry *elem0 = (struct acpi_probe_entry *)in0;

	struct acpi_probe_entry *elem1 = (struct acpi_probe_entry *)in1;



	return (elem0->type > elem1->type) - (elem0->type < elem1->type);

}



/*

 * On RISC-V, RINTC structures in MADT should be probed before any other

 * interrupt controller structures and IMSIC before APLIC. The interrupt

 * controller subtypes in MADT of ACPI spec for RISC-V are defined in

 * the incremental order like RINTC(24)->IMSIC(25)->APLIC(26)->PLIC(27).

 * Hence, simply sorting the subtypes in incremental order will

 * establish the required order.

 */

void arch_sort_irqchip_probe(struct acpi_probe_entry *ap_head, int nr)

{

	struct acpi_probe_entry *ape = ap_head;



	if (nr == 1 || !ACPI_COMPARE_NAMESEG(ACPI_SIG_MADT, ape->id))

		return;

	sort(ape, nr, sizeof(*ape), irqchip_cmp_func, NULL);

}