Unverified Commit f8c3ec43 authored by Peter Ujfalusi's avatar Peter Ujfalusi Committed by Mark Brown
Browse files

ASoC: SOF: loader: Drop SOF_DBG_DUMP_REGS flag when firmware start fails 



snd_sof_dsp_run() failure indicates that the DSP did not even booted up,
thus asking for dumping registers at this point is not valid.

Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: default avatarKai Vehmanen <kai.vehmanen@linux.intel.com>
Link: https://lore.kernel.org/r/20211006110645.26679-18-peter.ujfalusi@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent e5183890

sound/soc/sof/loader.c

+1 −2
Original line number Diff line number Diff line
@@ -820,8 +820,7 @@ int snd_sof_run_firmware(struct snd_sof_dev *sdev) 
	ret = snd_sof_dsp_run(sdev);

	if (ret < 0) {

		dev_err(sdev->dev, "error: failed to start DSP\n");

		snd_sof_dsp_dbg_dump(sdev, SOF_DBG_DUMP_REGS | SOF_DBG_DUMP_MBOX |

				     SOF_DBG_DUMP_PCI);

		snd_sof_dsp_dbg_dump(sdev, SOF_DBG_DUMP_MBOX | SOF_DBG_DUMP_PCI);

		return ret;

	}