Unverified Commit f8f62249 authored by Tudor Ambarus's avatar Tudor Ambarus
Browse files

mtd: spi-nor: winbond: add "w/ and w/o SFDP" comment 



Commit d35df777 ("mtd: spi-nor: winbond: fix w25q128 regression")
upstream fixed a regression for flavors of 0xef4018 flash that don't
define SFDP tables. Add a comment on the flash definition highlighting
that there are flavors of flashes with and without SFDP support.
It spares developers searching the entire git log for when we'll better
handle these cases.

Acked-by: default avatarPratyush Yadav <pratyush@kernel.org>
Link: https://lore.kernel.org/r/20241029080049.96679-1-tudor.ambarus@linaro.org


Signed-off-by: default avatarTudor Ambarus <tudor.ambarus@linaro.org>
parent b61c35e3

drivers/mtd/spi-nor/winbond.c

+1 −0
Original line number Diff line number Diff line
@@ -129,6 +129,7 @@ static const struct flash_info winbond_nor_parts[] = { 
		.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,

	}, {

		.id = SNOR_ID(0xef, 0x40, 0x18),

		/* Flavors w/ and w/o SFDP. */

		.name = "w25q128",

		.size = SZ_16M,

		.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB,