Unverified Commit f8fd138c authored by Fedor Pchelkin's avatar Fedor Pchelkin Committed by Ilpo Järvinen
Browse files

platform/x86: dell_rbu: avoid uninit value usage in packet_size_write() 



Ensure the temp value has been properly parsed from the user-provided
buffer and initialized to be used in later operations.  While at it,
prefer a convenient kstrtoul() helper.

Found by Linux Verification Center (linuxtesting.org) with Svace static
analysis tool.

Fixes: ad6ce87e ("[PATCH] dell_rbu: changes in packet update mechanism")
Signed-off-by: default avatarFedor Pchelkin <pchelkin@ispras.ru>
Link: https://patch.msgid.link/20260403134240.604837-1-pchelkin@ispras.ru


[ij: add include]
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 5969c55e

drivers/platform/x86/dell/dell_rbu.c

+5 −1
Original line number Diff line number Diff line
@@ -30,6 +30,7 @@ 
#define pr_fmt(fmt)	KBUILD_MODNAME ": " fmt



#include <linux/init.h>

#include <linux/kstrtox.h>

#include <linux/module.h>

#include <linux/slab.h>

#include <linux/string.h>
@@ -619,9 +620,12 @@ static ssize_t packet_size_write(struct file *filp, struct kobject *kobj, 
				 char *buffer, loff_t pos, size_t count)

{

	unsigned long temp;



	if (kstrtoul(buffer, 10, &temp))

		return -EINVAL;



	spin_lock(&rbu_data.lock);

	packet_empty_list();

	sscanf(buffer, "%lu", &temp);

	if (temp < 0xffffffff)

		rbu_data.packetsize = temp;