Commit f8ff23eb authored by Sebastian Andrzej Siewior's avatar Sebastian Andrzej Siewior Committed by Greg Kroah-Hartman
Browse files

serial: pch: Don't disable interrupts while acquiring lock in ISR. 



The interrupt service routine is always invoked with disabled
interrupts.

Remove the _irqsave() from the locking functions in the interrupts
service routine/ pch_uart_interrupt().

Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Link: https://lore.kernel.org/r/20240301215246.891055-16-bigeasy@linutronix.de


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 09b8ff26

drivers/tty/serial/pch_uart.c

+2 −3
Original line number Diff line number Diff line
@@ -1010,11 +1010,10 @@ static irqreturn_t pch_uart_interrupt(int irq, void *dev_id) 
	u8 lsr;

	int ret = 0;

	unsigned char iid;

	unsigned long flags;

	int next = 1;

	u8 msr;



	spin_lock_irqsave(&priv->lock, flags);

	spin_lock(&priv->lock);

	handled = 0;

	while (next) {

		iid = pch_uart_hal_get_iid(priv);
@@ -1074,7 +1073,7 @@ static irqreturn_t pch_uart_interrupt(int irq, void *dev_id) 
		handled |= (unsigned int)ret;

	}



	spin_unlock_irqrestore(&priv->lock, flags);

	spin_unlock(&priv->lock);

	return IRQ_RETVAL(handled);

}