Commit f92a39ae authored by Bert Karwatzki's avatar Bert Karwatzki Committed by Luben Tuikov
Browse files

drm/sched: Partial revert of "Qualify drm_sched_wakeup() by drm_sched_entity_is_ready()" 

Commit f3123c25, in combination with the use of work queues by the GPU
scheduler, leads to random lock-ups of the GUI.

This is a partial revert of of commit f3123c25 since drm_sched_wakeup() still
needs its entity argument to pass it to drm_sched_can_queue().

Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2994
Link: https://lists.freedesktop.org/archives/dri-devel/2023-November/431606.html



Signed-off-by: default avatarBert Karwatzki <spasswolf@web.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20231127160955.87879-1-spasswolf@web.de
Link: https://lore.kernel.org/r/36bece178ff5dc705065e53d1e5e41f6db6d87e4.camel@web.de


Fixes: f3123c25 ("drm/sched: Qualify drm_sched_wakeup() by drm_sched_entity_is_ready()")
Reviewed-by: default avatarLuben Tuikov <ltuikov89@gmail.com>
Signed-off-by: default avatarLuben Tuikov <ltuikov89@gmail.com>
parent 3cc808e3

drivers/gpu/drm/scheduler/sched_main.c

+2 −3
Original line number Diff line number Diff line
@@ -1029,7 +1029,6 @@ EXPORT_SYMBOL(drm_sched_job_cleanup); 
void drm_sched_wakeup(struct drm_gpu_scheduler *sched,

		      struct drm_sched_entity *entity)

{

	if (drm_sched_entity_is_ready(entity))

	if (drm_sched_can_queue(sched, entity))

		drm_sched_run_job_queue(sched);

}