Unverified Commit f92d27a6 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki Committed by Mark Brown
Browse files

ASoC: rockchip: Discard pm_runtime_put() return value 



It is better to check directly whether or not CONFIG_PM has
been enabled instead of relying on an error value returned by
pm_runtime_put() in that case because pm_runtime_put() may also return
an error value in other cases, like after writing "on" to the devices'
runtime PM "control" attribute in sysfs for one example.

This will facilitate a planned change of the pm_runtime_put() return
type to void in the future.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/5160923.0VBMTVartN@rafael.j.wysocki


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 9b7688c1

sound/soc/rockchip/rockchip_sai.c

+3 −2
Original line number Diff line number Diff line
@@ -1487,8 +1487,9 @@ static int rockchip_sai_probe(struct platform_device *pdev) 
	return 0;



err_runtime_suspend:

	/* If we're !CONFIG_PM, we get -ENOSYS and disable manually */

	if (pm_runtime_put(&pdev->dev))

	if (IS_ENABLED(CONFIG_PM))

		pm_runtime_put(&pdev->dev);

	else

		rockchip_sai_runtime_suspend(&pdev->dev);



	return ret;