Commit f92ff79b authored by Kohei Enju's avatar Kohei Enju Committed by Tejun Heo
Browse files

tools/sched_ext: fix scx_show_state.py for scx_root change 



Commit 48e12677 ("sched_ext: Introduce scx_sched") introduced
scx_root and removed scx_ops, causing scx_show_state.py to fail when
searching for the 'scx_ops' object. [1]

Fix by using 'scx_root' instead, with NULL pointer handling.

[1]
 # drgn -s vmlinux ./tools/sched_ext/scx_show_state.py
 Traceback (most recent call last):
   File "/root/.venv/bin/drgn", line 8, in <module>
     sys.exit(_main())
              ~~~~~^^
   File "/root/.venv/lib64/python3.14/site-packages/drgn/cli.py", line 625, in _main
     runpy.run_path(
     ~~~~~~~~~~~~~~^
         script_path, init_globals={"prog": prog}, run_name="__main__"
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     )
     ^
   File "<frozen runpy>", line 287, in run_path
   File "<frozen runpy>", line 98, in _run_module_code
   File "<frozen runpy>", line 88, in _run_code
   File "./tools/sched_ext/scx_show_state.py", line 30, in <module>
     ops = prog['scx_ops']
           ~~~~^^^^^^^^^^^
 _drgn.ObjectNotFoundError: could not find 'scx_ops'

Fixes: 48e12677 ("sched_ext: Introduce scx_sched")
Signed-off-by: default avatarKohei Enju <enjuk@amazon.com>
Reviewed-by: default avatarEmil Tsalapatis <emil@etsalapatis.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent ccaeeb58

tools/sched_ext/scx_show_state.py

+5 −2
Original line number Diff line number Diff line
@@ -27,10 +27,13 @@ def read_static_key(name): 
def state_str(state):

    return prog['scx_enable_state_str'][state].string_().decode()



ops = prog['scx_ops']

root = prog['scx_root']

enable_state = read_atomic("scx_enable_state_var")



print(f'ops           : {ops.name.string_().decode()}')

if root:

    print(f'ops           : {root.ops.name.string_().decode()}')

else:

    print('ops           : ')

print(f'enabled       : {read_static_key("__scx_enabled")}')

print(f'switching_all : {read_int("scx_switching_all")}')

print(f'switched_all  : {read_static_key("__scx_switched_all")}')