Commit f93fc5d1 authored by Kery Qi's avatar Kery Qi Committed by Jakub Kicinski
Browse files

net: octeon_ep_vf: fix free_irq dev_id mismatch in IRQ rollback 



octep_vf_request_irqs() requests MSI-X queue IRQs with dev_id set to
ioq_vector. If request_irq() fails part-way, the rollback loop calls
free_irq() with dev_id set to 'oct', which does not match the original
dev_id and may leave the irqaction registered.

This can keep IRQ handlers alive while ioq_vector is later freed during
unwind/teardown, leading to a use-after-free or crash when an interrupt
fires.

Fix the error path to free IRQs with the same ioq_vector dev_id used
during request_irq().

Fixes: 1cd3b407 ("octeon_ep_vf: add Tx/Rx processing and interrupt support")
Signed-off-by: default avatarKery Qi <qikeyu2017@gmail.com>
Link: https://patch.msgid.link/20260108164256.1749-2-qikeyu2017@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 16ce6e6f

drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c

+1 −1
Original line number Diff line number Diff line
@@ -218,7 +218,7 @@ static int octep_vf_request_irqs(struct octep_vf_device *oct) 
ioq_irq_err:

	while (i) {

		--i;

		free_irq(oct->msix_entries[i].vector, oct);

		free_irq(oct->msix_entries[i].vector, oct->ioq_vector[i]);

	}

	return -1;

}