Commit f9f281e8 authored by Gangliang Xie's avatar Gangliang Xie Committed by Alex Deucher
Browse files

drm/amdgpu: only check critical address when it is not reserved 



when an address is reserved already, no need to check if it is
in critical or not, to save time

Signed-off-by: default avatarGangliang Xie <ganglxie@amd.com>
Reviewed-by: default avatarHawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent a6ea0a43

drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

+4 −2
Original line number Diff line number Diff line
@@ -1922,8 +1922,6 @@ static ssize_t amdgpu_ras_sysfs_badpages_read(struct file *f, 


	for (i = 0; i < bps_count; i++) {

		address = ((uint64_t)bps[i].bp) << AMDGPU_GPU_PAGE_SHIFT;

		if (amdgpu_ras_check_critical_address(adev, address))

			continue;



		bps[i].size = AMDGPU_GPU_PAGE_SIZE;
@@ -1936,6 +1934,10 @@ static ssize_t amdgpu_ras_sysfs_badpages_read(struct file *f, 
		else

			bps[i].flags = AMDGPU_RAS_RETIRE_PAGE_RESERVED;



		if ((bps[i].flags != AMDGPU_RAS_RETIRE_PAGE_RESERVED) &&

		    amdgpu_ras_check_critical_address(adev, address))

			bps[i].flags = AMDGPU_RAS_RETIRE_PAGE_RESERVED;



		s += scnprintf(&buf[s], element_size + 1,

				"0x%08x : 0x%08x : %1s\n",

				bps[i].bp,