Commit fa0cac9a authored by David Carlier's avatar David Carlier Committed by Jens Axboe
Browse files

drbd: use get_random_u64() where appropriate 



Use the typed random integer helpers instead of
get_random_bytes() when filling a single integer variable.
The helpers return the value directly, require no pointer
or size argument, and better express intent.

Signed-off-by: default avatarDavid Carlier <devnexen@gmail.com>
Reviewed-by: default avatarChristoph Böhmwalder <christoph.boehmwalder@linbit.com>
Link: https://patch.msgid.link/20260405154704.4610-1-devnexen@gmail.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent a9c4b1d3

drivers/block/drbd/drbd_main.c

+2 −2
Original line number Diff line number Diff line
@@ -874,7 +874,7 @@ void drbd_gen_and_send_sync_uuid(struct drbd_peer_device *peer_device) 
	if (uuid && uuid != UUID_JUST_CREATED)

		uuid = uuid + UUID_NEW_BM_OFFSET;

	else

		get_random_bytes(&uuid, sizeof(u64));

		uuid = get_random_u64();

	drbd_uuid_set(device, UI_BITMAP, uuid);

	drbd_print_uuids(device, "updated sync UUID");

	drbd_md_sync(device);
@@ -3337,7 +3337,7 @@ void drbd_uuid_new_current(struct drbd_device *device) __must_hold(local) 
	u64 val;

	unsigned long long bm_uuid;



	get_random_bytes(&val, sizeof(u64));

	val = get_random_u64();



	spin_lock_irq(&device->ldev->md.uuid_lock);

	bm_uuid = device->ldev->md.uuid[UI_BITMAP];

drivers/block/drbd/drbd_nl.c

+1 −1
Original line number Diff line number Diff line
@@ -3236,7 +3236,7 @@ int drbd_adm_resume_io(struct sk_buff *skb, struct genl_info *info) 
			 * matching real data uuid exists).

			 */

			u64 val;

			get_random_bytes(&val, sizeof(u64));

			val = get_random_u64();

			drbd_set_ed_uuid(device, val);

			drbd_warn(device, "Resumed without access to data; please tear down before attempting to re-configure.\n");

		}