Commit fa17f749 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpiolib: unify two loops initializing GPIO descriptors 



We currently iterate over the descriptors owned by the GPIO device we're
adding twice with the first loop just setting the gdev pointer. It's not
used anywhere between this and the second loop so just drop the first
one and move the assignment to the second.

Reviewed-by: default avatarKent Gibson <warthog618@gmail.com>
Link: https://lore.kernel.org/r/20241004-gpio-notify-in-kernel-events-v1-2-8ac29e1df4fe@linaro.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent ee194b12

drivers/gpio/gpiolib.c

+2 −3
Original line number Diff line number Diff line
@@ -1026,9 +1026,6 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, 
		}

	}



	for (desc_index = 0; desc_index < gc->ngpio; desc_index++)

		gdev->descs[desc_index].gdev = gdev;



	BLOCKING_INIT_NOTIFIER_HEAD(&gdev->line_state_notifier);

	BLOCKING_INIT_NOTIFIER_HEAD(&gdev->device_notifier);
@@ -1058,6 +1055,8 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, 
	for (desc_index = 0; desc_index < gc->ngpio; desc_index++) {

		struct gpio_desc *desc = &gdev->descs[desc_index];



		desc->gdev = gdev;



		if (gc->get_direction && gpiochip_line_is_valid(gc, desc_index)) {

			assign_bit(FLAG_IS_OUT,

				   &desc->flags, !gc->get_direction(gc, desc_index));